1366 filtering on some pages broken#1371
Merged
Merged
Conversation
…er on it as a simple integer where required.
…Name property rather than custom filtering based on pattern matching and Linq.
…nager filtering. Also adjusted filtering by CurrentGrade to use a calculated integer value.
…te rather than being set in the calling code.
… been moved into the entity.
2 tasks
Adjusted Faculty and School filtering to use the Code for each as the filterable property. Removed filter from some columns where it didn't make much sense (costs, day rate, dates etc.)
PhilBradbury
requested review from
aharwood2,
gdonval,
philiptharrison and
sjmf
as code owners
aharwood2
requested changes
Jun 11, 2026
aharwood2
left a comment
aharwood2
left a comment
Member
There was a problem hiding this comment.
I think this probably needs a walkthrough so I can see the differences more clearly. Will need to check that the changes don't alter the UX in a way they might not like.
Contributor
Author
|
Walkthrough video now available at: https://www.loom.com/share/f3190d9bb90a4faeab6a5f51ef56f16e The egregious bracket after the value in one of the monetary columns has been removed. |
… to have a property to hold FundsReceived data to be able to filter on that.
…com/UoMResearchIT/CapX into 1366-filtering-on-some-pages-broken
Contributor
Very nice @PhilBradbury - thanks much! |
aharwood2
reviewed
Jun 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the broken/crashing filtering behavior on the People and Manage Projects pages (issue #1366), likely triggered by changes in Radzen’s filtering behavior, by shifting filtering/sorting back toward Radzen’s built-in mechanisms and introducing grid-friendly derived properties.
Changes:
- Adjust Radzen DataGrid filtering mode/config and align column
FilterProperty/SortPropertywith actual nested fields (e.g.,School.Faculty.Code,LineManager.Name). - Introduce derived, non-persisted properties to support filtering in grids (
Project.FundsReceived,Person.CurrentGrade). - Remove/reshape custom filtering logic in the page code-behind to reduce filter crashes and improve paging/counting behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| PPMTool/Pages/Projects.razor.cs | Populates FundsReceived for grid filtering; removes custom Faculty/School filtering block. |
| PPMTool/Pages/Projects.razor | Updates grid/column filter modes and adds typed/date/numeric filter configuration; switches to filtering on nested School/Faculty properties. |
| PPMTool/Pages/People.razor.cs | Simplifies custom filtering to SkillTags only; relies on Radzen’s args.Filter for other filters; updates sorting/paging/count flow. |
| PPMTool/Pages/People.razor | Updates Line Manager column to filter/sort by LineManager.Name; disables filtering on problematic derived columns; switches grade display to CurrentGrade. |
| PPMTool.Data/Entities/Project.cs | Adds [NotMapped] FundsReceived to support grid filtering. |
| PPMTool.Data/Entities/Person.cs | Adds [NotMapped] CurrentGrade to support grid filtering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…com/UoMResearchIT/CapX into 1366-filtering-on-some-pages-broken
…ity on data grid load
…verriding of LINQ-based filtering consistently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1366